Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition domain of the ACOS function #487

Closed
karimall72 opened this issue Jun 28, 2024 · 0 comments · Fixed by #489
Closed

Definition domain of the ACOS function #487

karimall72 opened this issue Jun 28, 2024 · 0 comments · Fixed by #489

Comments

@karimall72
Copy link

Evaluation of ACOS(-2) throws a NumberFormatException.

It would be preferable to throw an EvaluationException, as you have already done for the ASIN() function.

See issue #361: Evaluation of asin(1.5) will throw NumberFormatException which is a bit misleading

Remark:
There could be another way (the basic Java way for invalid math) for this general topic : to accept that EvaluationValue could hold Double.NaN or Float.NaN. But it is a matter of choice…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants