Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*.brep default config is missing #1505

Closed
Meakk opened this issue Jun 30, 2024 · 2 comments
Closed

*.brep default config is missing #1505

Meakk opened this issue Jun 30, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Please help with this issue! source:F3DApplication type:bug Something isn't working
Milestone
3.1.0

Comments

@Meakk
Copy link
Contributor

Meakk commented Jun 30, 2024 •
edited by mwestphal
Loading

Describe the bug
The *.brep default config is missing.
It should be the same as *.step and *.iges files

Context
Each plugin in F3D is responsible to describe the configuration to use for each format
The OCCT plugin provide support for .brep file, but the config is missing.

Solution

  • Add brep in plugins/occt/configs/*.d/10_occt.json
  • Check it works with brep file
@Meakk Meakk added this to the 3.0.0 milestone Jul 1, 2024
@mwestphal mwestphal added type:bug Something isn't working good first issue Good for newcomers help wanted Please help with this issue! source:F3DApplication labels Jul 4, 2024
@mwestphal mwestphal modified the milestones: 3.0.0, 3.1.0 Jul 13, 2024
@NWc0de
Copy link
Contributor

NWc0de commented Jul 20, 2024

pull request for this (:

#1546

@Meakk
Copy link
Contributor Author

Meakk commented Jul 20, 2024

PR merged, closing it

@Meakk Meakk closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Please help with this issue! source:F3DApplication type:bug Something isn't working
Projects
F3D
Status: Done
Milestone
3.1.0
Development

No branches or pull requests
3 participants
@mwestphal @Meakk @NWc0de