Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Alembic reader #913

Open
3 of 5 tasks
mwestphal opened this issue Jul 12, 2023 · 20 comments
Open
3 of 5 tasks

Improve Alembic reader #913

mwestphal opened this issue Jul 12, 2023 · 20 comments
Assignees
Labels
type:enhancement New feature or request
Milestone

Comments

@mwestphal
Copy link
Contributor

mwestphal commented Jul 12, 2023

Is your feature request related to a problem? Please describe.
Since #138 was closed, F3D has been supporting alembic file format, however the support is fairly limited, let's improve it.

Missing features:

  • Animation support
  • Texture Coordinates
  • Normals
  • Reuse the face varying filter
  • performance (I tried a large file which takes ~5 seconds per frame, but it's fast on Blender)
@mwestphal
Copy link
Contributor Author

mwestphal commented Jul 12, 2023

@Meakk : Since you already looked at that, which feature should we had in the list above ?

@gerroon @nyue : Please let me know your thougts on this

@Meakk
Copy link
Contributor

Meakk commented Jul 12, 2023

Normals, texture coordinates, and animation.
Please note that in the case of animation, there's no skinning as far as I know. It's only time-dependent buffers so quite easy to support.

@gerroon
Copy link

gerroon commented Jul 13, 2023

I think the current alembic reader shows objects in the center of the world, it might be the animation data thing.

@mwestphal
Copy link
Contributor Author

@gerroon : Do you have an example file ?

@mwestphal
Copy link
Contributor Author

FYI VTK is currently adding a vtkAlembicExporter, we could hope our importer could be integrated in VTK and improved by the VTK community.

@nyue
Copy link
Contributor

nyue commented Sep 17, 2023

Apologies, I have been away for sometime.

I am happy to help out on the Alembic specific, especially with getting (1) Normal (2) Texture Coordinate into/out-of Alembic.

However, I am unable to find the time to be able to re-wrap my head around F3D specifics.

For example, someone can ask "please provide a C++ example to query geometry normals from an Alembic file", that type of question I am able to find the time to put them together. If it becomes the wider question about how that will transfer to F3D, I will be too slow to be productively helpful as I have to dive into F3D itself and understand the underlying design and best practices of F3D.

If the above arrangement (me helping someone familiar with F3D), yes, I can participate.

Kind regards.

@mwestphal
Copy link
Contributor Author

@nyue of course we can help, do you use discord ?
https://discord.f3d.app

@nyue
Copy link
Contributor

nyue commented Sep 17, 2023

@mwestphal I do use Discord and I have now joined f3d on discord.

@mwestphal mwestphal added this to the 2.3.0 milestone Oct 1, 2023
@mwestphal mwestphal added the type:enhancement New feature or request label Oct 1, 2023
@mwestphal
Copy link
Contributor Author

Partially done in #1069

@mwestphal
Copy link
Contributor Author

@Meakk do you still plan to do the animation part ?

@Meakk
Copy link
Contributor

Meakk commented Dec 3, 2023

Yes I will. I have animated files to work on.

@mwestphal mwestphal modified the milestones: 2.3.0, 2.4.0 Dec 21, 2023
@mwestphal mwestphal added the help wanted Please help with this issue! label Jan 7, 2024
@mwestphal mwestphal removed the help wanted Please help with this issue! label Jan 26, 2024
@mwestphal mwestphal modified the milestone: 2.4.0 Feb 3, 2024
@Meakk Meakk self-assigned this Mar 29, 2024
@mwestphal
Copy link
Contributor Author

done in #1340

@Meakk
Copy link
Contributor

Meakk commented Mar 31, 2024

Let me reopen that issue. I see 2 points to improve:

  • reuse the face varying filter
  • performance (I tried a large file which takes ~5 seconds per frame, but it's fast on Blender)

@Meakk Meakk reopened this Mar 31, 2024
@mwestphal
Copy link
Contributor Author

good points, I've added them on top.

@mwestphal
Copy link
Contributor Author

But its a reader, not an importer, so no textures supported anyway ?

@Meakk
Copy link
Contributor

Meakk commented Mar 31, 2024

Texture coordinates are supported but AFAIK there's no material description described by the format itself.
Alembic is mainly used to export baked simulation.

@mwestphal
Copy link
Contributor Author

Ha, got it.

@gerroon
Copy link

gerroon commented Mar 31, 2024

Alembic should support polygon tags to define where the materials are applied but it is a format that wont really support texture/material data, most users of alembic would expect to have material previews with alembic.

@Meakk
Copy link
Contributor

Meakk commented Mar 31, 2024

@gerroon what do you mean by material previews? Some kind of texture placeholder like a checkboard?

@gerroon
Copy link

gerroon commented Mar 31, 2024

@gerroon what do you mean by material previews? Some kind of texture placeholder like a checkboard?

What I meant is that the alembic users would know the limitation, it is a format for specialized use case really.

@mwestphal mwestphal modified the milestones: 2.4.0, 2.5.0 Apr 4, 2024
@mwestphal mwestphal modified the milestones: 2.5.0, 3.0.0 Jul 3, 2024
@mwestphal mwestphal modified the milestones: 3.0.0, 3.1.0 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

4 participants