Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building 'demodadsb' #2333

Closed
gvanem opened this issue Nov 15, 2024 · 3 comments · Fixed by #2334
Closed

Error building 'demodadsb' #2333

gvanem opened this issue Nov 15, 2024 · 3 comments · Fixed by #2334

Comments

@gvanem
Copy link

gvanem commented Nov 15, 2024

Using MSVC on Win-10 to build the demodadsb plugin, causes this error:

adsbdemodsinkworker.h(54): error C2079: 'ADSBDemodSinkWorker::MsgConfigureADSBDemodSinkWorker::m_settings' uses undefined struct 'ADSBDemodSettings' 
adsbdemodsinkworker.h(79): error C2079: 'ADSBDemodSinkWorker::m_settings' uses undefined struct 'ADSBDemodSettings'
adsbdemodsinkworker.h(44): error C2440: 'return': cannot convert from 'const int' to ' const ADSBDemodSettings &' 
...

But with this change it now builds for me:

--- a/adsbdemodsinkworker.h 2024-11-15 09:16:23
+++ b/adsbdemodsinkworker.h 2024-11-15 10:39:28
@@ -26,6 +26,7 @@
 #include "util/message.h"
 #include "util/messagequeue.h"
 #include "adsbdemodstats.h"
+#include "adsbdemodsettings.h"

 class ADSBDemodSink;
-struct ADSBDemodSettings;
-struct ADSBDemodStats;
@srcejon
Copy link
Collaborator

srcejon commented Nov 15, 2024

Using MSVC
What version?

@gvanem
Copy link
Author

gvanem commented Nov 15, 2024

Version 19.42.34430 for x64. The latest.

@srcejon
Copy link
Collaborator

srcejon commented Nov 15, 2024

Happy to change it - but wondering why I don't see it myself with MSVC.

What's the rest of the error (i.e. what's including it)? Are you trying to use PCHs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants