Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Examples Requests with web proxy support #88

Open
walterk82 opened this issue Nov 9, 2020 · 11 comments
Open

[RFE] Examples Requests with web proxy support #88

walterk82 opened this issue Nov 9, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@walterk82
Copy link

I'm having difficulty getting the examples from github to load in VS.Code. I have tried the URL in my browser and it loads fine. Is there something missing that would cause web proxy servers to be bypassed? Extension downloads thru VS.Code work just fine.

@DumpySquare
Copy link
Member

Yes, you are correct. The extension does not have any knowledge of proxies. and attempts to go direct.

We can look into trying to detect and use system proxy settings, if not, look into provide a configuration option within the extension.

@DumpySquare DumpySquare self-assigned this Nov 9, 2020
@DumpySquare DumpySquare added the enhancement New feature or request label Nov 9, 2020
@DumpySquare DumpySquare changed the title Examples Requests with web proxy support [RFE] Examples Requests with web proxy support Nov 9, 2020
@DumpySquare DumpySquare added the inProgress feature/fix in development label Nov 10, 2020
@DumpySquare DumpySquare added this to the v3.0 enhancements/refactor milestone Mar 5, 2021
@DumpySquare
Copy link
Member

@walterk82 I've been working on this as part of the v3.0 release for you. Can you provide any details or example of your proxy configuration? I know we need a destination:port, but I guess my main question is, do you also need to provide a username/password?

@walterk82
Copy link
Author

Our proxy uses integrated auth (Kerberos) on Windows. I would have thought VS.Code provide a framework for this type of communication.

@DumpySquare
Copy link
Member

Right. VSCode itself does have a way to tap into the local system network settings for proxy configuration but they do not provide a way for extensions to do the same, or make external HTTP calls through the core VSCode process (to utilize the local network/proxy settings).

I will keep digging to see what I can come up with. If we have to hold user creds for proxy auth, we can secure the password storage the same way we are storing passwords for connecting to F5 devices. Not ideal, but a workable solution.

@walterk82
Copy link
Author

This seems overly complicated. I think that using links to github and opening a browser version is just fine. It keeps the security clean, simple, and less code for you to maintain. I don't think you should have to re-write interacting with github in Node.JS for the conveniences of presenting these examples in a tree view. I would hope that the github organization would be so straight forward to find the required examples.

@DumpySquare
Copy link
Member

ok. sounds like we can table this for now. I still think there is value in having proxy support for enterprise environments like yours. Does the ATC ILX RPM download/install function work for you (it downloads rpms from github)?

https://f5devcentral.github.io/vscode-f5/#/atc_rpm_mgmt

@walterk82
Copy link
Author

I don't have a quick way to test that as the RPMs are large and I don't load them over a VPN connection. I also don't have a DEV VS.Code environment within the DataCenter to test with. I have been loading them via GUI from a JumpBox.

@DumpySquare
Copy link
Member

Ok. I'm gonna push this feature for a later release.

@DumpySquare DumpySquare removed this from the v3.0 enhancements/refactor milestone Mar 24, 2021
@DumpySquare DumpySquare removed the inProgress feature/fix in development label Mar 24, 2021
@DumpySquare
Copy link
Member

Hey @walterk82, are you still having this issue? I'm hoping this might have gotten better with all the latest updates.

@walterk82
Copy link
Author

Browsing the examples tree I see the following console output:

[2021-05-27T14:34:43.592Z] ERROR: {
message: 'EXTERNAL-HTTPS-REQUEST-FAILED',
path: undefined,
err: 'Socket is closed'
}

@DumpySquare
Copy link
Member

hrmmm. ok. thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants