[registry] fallback to given local IP address #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabio has configuration for every IP binding, but relies on autodetection for registration with Consul. I propose falling back to the IP given in the config. I ran into this issue on SmartOS, where Go did not detect a local IP from my 3 VLANs.
magiconair
added a commit
that referenced
this pull request
Dec 15, 2015
[registry] fallback to given local IP address
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabio has configuration for every IP binding, but relies on autodetection for registration with Consul. I propose falling back to the IP given in the config.
I ran into this issue on SmartOS, where Go did not detect a local IP from my 3 VLANs. You may already be changing the address config (#28), please consider this in the new version.
Fabio runs great otherwise on SmartOS. Thanks for your work!