Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vault 0.10 KV v2 #483

Closed
danlsgiga opened this issue Apr 13, 2018 · 5 comments
Closed

Add support for Vault 0.10 KV v2 #483

danlsgiga opened this issue Apr 13, 2018 · 5 comments

Comments

@danlsgiga
Copy link
Contributor

Since Vault 0.10 introduced the secret backend KV v2, the data structure and API endpoints to retrieve certificates has also changed. For now we are keeping our certificates mountpoint on v1 but it would be great to have Fabio supporting KV v2 as well.

@magiconair
Copy link
Contributor

Can you provide a PR?

@pschultz
Copy link
Member

pschultz commented May 17, 2018

@danlsgiga, judging from the patch in #497, it looks like all you have to do to use the V2 backend is to update your Fabio config from

cs=<name>;type=vault;cert=secret/fabio/certs

to

cs=<name>;type=vault;cert=secret/data/fabio/certs

There doesn't seem to be a change required in Fabio itself.

Update: My test runs were false negatives. There are changes required after all.

@danlsgiga
Copy link
Contributor Author

Hi @pschultz, yeah, before submitting the issue I've tried Fabio with the newer path structure used in v2 but it didn't work. Thanks for looking into it though!

@pschultz
Copy link
Member

pschultz commented Sep 20, 2018

This is addressed by #497 and can be closed now.

@aaronhurt
Copy link
Member

@pschultz Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants