Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Template Version [hash7/8] #6

Closed
marcoris opened this issue Nov 16, 2018 · 3 comments
Closed

Template Version [hash7/8] #6

marcoris opened this issue Nov 16, 2018 · 3 comments

Comments

@marcoris
Copy link

Hi Fabio
excellent plugin you have made.
I have an Issue about the bump.templates.version with hash7/8.
I.e.
"bump.templates.version": "#[[version]](https://bitbucket.org/MYNAME/commits/[hash8]) ([version_date])"
Should output the correct hash in the link, but it dont do it. In the text is the correct hash. I also tested [hash7] and [hash8].

In the bump.templates.commit it is outputting the correct hash.
"bump.templates.commit": "- [message] ([[hash7]](https://bitbucket.org/MYNAME/commits/[hash7]))"

Is it also possible to check if the bump was a major and then style the template different? So i can add one # in major bump and two # for minor bump and so on?

Thx

@fabiospampinato
Copy link
Owner

Should output the correct hash in the link, but it dont do it.

I'll have to think more about this, but since we update the changelog before making the bump commit I don't think you can do what you describe.

Is it also possible to check if the bump was a major and then style the template different?

I could add support for this, but I'm not sure if it would be that useful, after all how often do you make major releases? Right now you should manually modify the changelog and eventually amend the bump commit.

@marcoris
Copy link
Author

Ok thanks for your response.

@fabiospampinato
Copy link
Owner

On a second thought I think there are some good features that should be implemented:

I'm closing this issue in favor of them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants