Remove deprecated avatars and uploads implementation #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscgonfer this is up on staging - if when you get a sec you could confirm that everything looks correct in the UI (ie, nothing has changed vs on production) that'd be amazing! no rush though |
timcowlishaw
force-pushed
the
remove-deprecated-avatars-v2
branch
from
9849cc2
to
eb83da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last step on #166 which we missed at the time - reopening a new PR as it was simpler than rebasing the old one and dealing with the conflicts. It makes sense to do this before the rethinking of the json serializations i think!
This completely removes the deprecated user "avatar" property and "upload" model - all users (apart from two) have had their avatars migrated to use the new profile picture property, and the frontend has already been updated to use profile_picture exclusively.
Maybe worth a test on staging (with the UI) before deploying, but this shouldn't change anything user facing