Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using routes (react-router) #2

Open
4 tasks
viktorsmari opened this issue Mar 7, 2019 · 2 comments
Open
4 tasks

Using routes (react-router) #2

viktorsmari opened this issue Mar 7, 2019 · 2 comments

Comments

@viktorsmari
Copy link
Collaborator

viktorsmari commented Mar 7, 2019

We need to decide which routes to use

Final routes:

  • /4556
  • /4556?biggraph=true indicates the 'biggraph' at the bottom should be 'ON'
  • /map will show the map but I don't think it makes sense to keep the kit selected
  • /map/nearby will show nearby kits on the map, and no need to keep the kit selected

Examples / suggestions:

  • /4556 - shows kit 4556 on the page
  • /4556?biggraph=true - Same as above + Big Graph is visible
  • /map - shows the map? But is the kit then still selected or not?
  • /nearby - Show nearby kits in a table? Or on the map? And is the kit still selected or not?
  1. Do we need more routes?
  2. Can we use ..me/1234 for the kits or will it clash with another route?
@tuengominh
Copy link

My opinion:

  • /4556 & 4556?biggraph=true is necessary.
  • /map will show the map but I don't think it makes sense to keep the kit selected
  • /map/nearby will show nearby kits on the map, and no need to keep the kit selected
  • Do you think we should have some routes for owner id, with data from all devices of that owner?

@viktorsmari
Copy link
Collaborator Author

Sure, if you feel like that is something you would want, 'as a user' 👤
Keep the ideas coming, and I will add a 'Final' section at the top of the issue, as we discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants