Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename booking status "VALIDATED" -> "COMPLETED" #43

Open
pierrecamilleri opened this issue Sep 21, 2022 · 0 comments · May be fixed by #48
Open

Rename booking status "VALIDATED" -> "COMPLETED" #43

pierrecamilleri opened this issue Sep 21, 2022 · 0 comments · May be fixed by #48

Comments

@pierrecamilleri
Copy link
Collaborator

The possible values of a booking status are currently the following :
[ WAITING_CONFIRMATION, CONFIRMED, CANCELLED, COMPLETED_PENDING_VALIDATION, VALIDATED ]

I find the last one, "VALIDATED", unclear and error-prone, as it can be easily confused with "CONFIRMED".

I would suggest changing it to "COMPLETED".
@pierrecamilleri pierrecamilleri linked a pull request Oct 10, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change VALIDATED to COMLETED fabmob/standard-covoiturage
1 participant
@pierrecamilleri