Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spacing): Changed value of $space-xxl to 3rem #78

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

fragsalat
Copy link
Contributor

  • changed $space-xxl to 3rem
  • added variable $space-xxxl with 4rem

@tonysaad @wholesale-design-system/engineers @inanda This might be a breaking change for your applications so if you update to a new version of the scss repository keep track on that!

@fokusferit
Copy link
Contributor

I think before we merge these changes:

@tonysaad and @inanda should check with their applications how these new changes might affect their application.

As it is a breaking change, I don't want to create much burden for production systems.

@tonysaad
Copy link
Contributor

I'm planning a live-deploy today, thinking to postpone merging this branch until we change the names so I don't have to do double work

Copy link
Contributor

@tonysaad tonysaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (Y) but will prefer to merge tomorrow

@fragsalat fragsalat merged commit f3d0a8c into master Aug 31, 2017
@fragsalat fragsalat deleted the new-spacing-variable branch August 31, 2017 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants