Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Add "Branch" edit box to import card #938

Open
quintesse opened this issue Mar 29, 2019 · 4 comments
Open

Add "Branch" edit box to import card #938

quintesse opened this issue Mar 29, 2019 · 4 comments
Assignees
Labels
component/frontend Issues that impact the frontend

Comments

@quintesse
Copy link
Contributor

It would be great to have a place to type the name of the Git branch below or next to the place where you can enter the URL. By default it would be master, but you would be allowed to type any other name there. This value would then be passed to the /import/analyze and /import/launch endpoints as gitImportBranch.

Extra points if we could make it a dropdown with the result from the /import/branches endpoint (this only takes a gitImportUrl value and returns a list of branch names). But I can imagine that's too much work for tomorrow (Friday 29th, the day we have to release).

@ALRubinger
Copy link

Right: or "ref", which can be any valid ref like a tag or SHA. Exactly.

@ALRubinger
Copy link

(Consider it part of "not the train we just did") - continuous pushing new features is fine!

edewit referenced this issue in edewit/launchpad-frontend Mar 29, 2019
@quintesse
Copy link
Contributor Author

@ALRubinger yeah, they're really called refs, but I took the name from the option that's being used in the git clone command itself: it uses --branch and then says in the docs that it also allows tag names.

@ALRubinger
Copy link

Taking usability hints from the git command-line client HAHAHAHAHAHA thanks there buddy I needed a laugh.

@ia3andy ia3andy transferred this issue from fabric8-launcher/launcher-ui-components Aug 12, 2019
@ia3andy ia3andy added the component/frontend Issues that impact the frontend label Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component/frontend Issues that impact the frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants