Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Dirty NPE in NativeGitBoosterCatalogPathProvider.createBoosterContentPath #46

Open
ia3andy opened this issue Apr 17, 2018 · 1 comment
Open

Dirty NPE in NativeGitBoosterCatalogPathProvider.createBoosterContentPath #46

ia3andy opened this issue Apr 17, 2018 · 1 comment
Labels
bug

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Apr 17, 2018

the code in NativeGitBoosterCatalogPathProvider.createBoosterContentPath can be dangerous
booster.getGitRepo() and booster.getGitRef() are both @Nullable and can lead to a dirty ProcessBuilder NPE.

Caused by: java.lang.NullPointerException
    at java.lang.ProcessBuilder.start(ProcessBuilder.java:1012)
    at io.fabric8.launcher.booster.catalog.spi.NativeGitBoosterCatalogPathProvider.createBoosterContentPath(NativeGitBoosterCatalogPathProvider.java:89)
    at io.fabric8.launcher.booster.catalog.AbstractBoosterCatalogService.lambda$fetchBoosterContent$4(AbstractBoosterCatalogService.java:194)
    ... 9 more
@ia3andy ia3andy added the bug label Apr 17, 2018
@ia3andy
Copy link
Contributor Author

ia3andy commented May 9, 2018

it seems to happen with an invalid/outdated catalog

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ia3andy