Add parameter to allow skipping of tagging #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Could you add some documentation to manual.md and add to changelog.md ? Just out of curiosity: What is your use case for skipping configured tags ? |
|
This used to be a CI issue when creating docker images tagged with the git commit ID. The current solution is a special profile in the POM for that. Not a big deal, but with the skipTags property there wouldn't have been the need to change the POM. |
|
Added some lines to the docs. I wasn't sure if I did it right for the change log, though. |
Signed-off-by: Tom Wieczorek <tom@bibbu.net>
|
Applied for 0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naive approach to be able to skip tagging of images during
docker:buildusing a property. Whendocker.skipTagsistrue, then built images won't be tagged.