Allow dynamic ports to be override by System properties. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior only allowed project properties to override them. Even the documentation suggested that you could override them by passing -Dfoo=bar on the mvn cli, but this wasn't actually the case. Signed-off-by: Ben Reser <ben.reser@cdk.com>
|
Thanks, you are right. The behaviour is not as described in the manual. Your fix is straight forward, I will polish it a bit and it will make it into 0.11.4. |
rhuss
added a commit
that referenced
this pull request
May 13, 2015
Tuned up #161 a bit. Also, added a unit test.
leusonmario
pushed a commit
to leusonmario/docker-maven-plugin
that referenced
this pull request
Aug 18, 2018
Added new Feature so that volumes can be specified in POM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior only allowed project properties to override them.
Even the documentation suggested that you could override them by passing
-Dfoo=bar on the mvn cli, but this wasn't actually the case.
Signed-off-by: Ben Reser ben.reser@cdk.com