Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce logging of hubot #219

Open
maxandersen opened this issue May 1, 2017 · 0 comments
Open

reduce logging of hubot #219

maxandersen opened this issue May 1, 2017 · 0 comments
Assignees

Comments

@maxandersen
Copy link

When I have a pipeline without any hubot configured I still see:

[Pipeline] hubotApprove
Hubot sending to room fabric8_default => Would you like to promote version 2.0.1 to the next environment?

    to Proceed reply:  fabric8 jenkins proceed job maxandersen/mirror/master build 1
    to Abort reply:    fabric8 jenkins abort job maxandersen/mirror/master build 1

No service hubot  is running!!!
No service found!

Two things come to mind:

  1. why does it even tell me about hubot when I don't have it running. I assume for many this would be the default and thus 9 lines of output is wasteful. If it must do something maybe only do 1 line like Service hubot is not running!

  2. shouldn't enable/disablement of features in the shared jenkins pipeline be something controlled by the user ? i.e. by the user enable/disabling extensions rather than it is defined in the world global: github.com/fabric8io/fabric8-pipeline-library@master ?

@rajdavies rajdavies self-assigned this May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants