Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutiple ways to get github token #402

Open
sthaha opened this issue Apr 26, 2018 · 0 comments
Open

Remove mutiple ways to get github token #402

sthaha opened this issue Apr 26, 2018 · 0 comments

Comments

@sthaha
Copy link
Contributor

sthaha commented Apr 26, 2018

I find that there are two ways to fetch github token in the pipeline library

  1. withCredentials to lookup cd-github see:
    withCredentials([usernamePassword(credentialsId: 'cd-github', passwordVariable: 'PASS', usernameVariable: 'USER')]) {
  2. Fabric8Command.getGitHubToken which uses a different mechanism. See:

Lets ensure there is only one way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant