Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting informers in case of errors #2594

Closed
thmshmm opened this issue Nov 9, 2020 · 2 comments
Closed

Restarting informers in case of errors #2594

thmshmm opened this issue Nov 9, 2020 · 2 comments

Comments

@thmshmm
Copy link

thmshmm commented Nov 9, 2020

Hello,
how can informer errors be handled? In my case the informer for the CRD sometimes fails for example with JSON parse exceptions.

I am aware of registering a listener via "addSharedInformerEventListener" but trying to restart the informers using "stopAllRegisteredInformers" and "startAllRegisteredInformers" has no effect.

When I try to only stop the informer(s) there are some background threads which are still around after using "stopAllRegisteredInformers". Closing the OpenShift client leads to exceptions reported by a watcher but the thread is still running.

Kr thms

@manusa manusa added the bug label Nov 16, 2020
@stale
Copy link

stale bot commented Apr 8, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Apr 8, 2021
@stale stale bot closed this as completed May 6, 2021
@manusa
Copy link
Member

manusa commented May 6, 2021

Relates to: #2010

This issue might have been tackled by the many recent improvements and refactors dealing with Shared Informers. Note that now Informers can only be started once in their lifecycle. They should be resilient and self-healing. In case of failure, it should be reported and user is responsible to regenerate them (#3050, #3073, #3013)

Please feel free to reopen the issue if it still applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants