Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Watch.close so that error can always be reported #2614

Closed
metacosm opened this issue Nov 20, 2020 · 1 comment · Fixed by #2616
Closed

Improve Watch.close so that error can always be reported #2614

metacosm opened this issue Nov 20, 2020 · 1 comment · Fixed by #2616
Assignees
@manusa
Milestone
5.0.0

Comments

@metacosm
Copy link
Collaborator

@manusa's idea:

Change the onClose signature to have a dedicated exception parameter i.e. WatcherException. This exception should only have a constructor with the message and cause. So on the calling methods, we should always propagate the cause.
@manusa manusa self-assigned this Nov 20, 2020
@manusa manusa added this to the 5.0.0 milestone Nov 20, 2020
@manusa
Copy link
Member

manusa commented Nov 20, 2020

Relates to: #2273

@manusa manusa mentioned this issue Nov 20, 2020
Merged
11 tasks
@manusa manusa mentioned this issue Dec 17, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

refactor: Watcher.onClose has dedicated WatcherException as parameter. manusa/kubernetes-client
2 participants
@metacosm @manusa