Generated crd has a validation error

[shawkins]

With crd-generator 5.2.1 my installed generated crd is reporting:

conditions:
  - lastTransitionTime: "2021-05-06T14:56:48Z"
    message: 'spec.preserveUnknownFields: Invalid value: true: must be false'
    reason: Violations
    status: "True"
    type: NonStructuralSchema

There's nothing on the custom resource class nor in the generated yml that mentions preserveUnknownFields.

cc @metacosm

[metacosm]

That's indeed weird. Can you try with a more recent version of the crd-generator-apt, please? Note that it's highly unlikely that we would backport fixes to 5.2.x. You should be able to use the crd-generator-apt dependency with a different version without it impacting the rest of the code, though.

[metacosm]

After some investigation, that seems to be an issue with upgrading CRDs from v1beta1 to v1. See https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#field-pruning for more information. The fix seems to manually set preserveUnknownFields to false in your CRD.

[shawkins]

This situation is occurring with a fresh minikube and the v1beta1 crd.

It does not appear to happen when starting fresh and applying the v1 crd.

I'm fine with a manual workaround.

[metacosm]

This situation is occurring with a fresh minikube and the v1beta1 crd.

You mean it happens with just the v1beta1 CRD? Not an upgrade scenario?

[shawkins]

You mean it happens with just the v1beta1 CRD? Not an upgrade scenario?

Yes. minikube delete, then start, then "kubectl apply -f ...", then "kubectl get crd ..." and the validation error is there.

[metacosm]

Not that this behavior seems to happen starting with kube 1.20, applying the CRD to 1.19 didn't lead to the validation error.

[metacosm]

Can we close this issue?

[shawkins]

Yes, the resolution is to manually change the generated crd and the problem will go away with v1.