Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Fabric8 Knative Extension Model to v0.37.0 #5140

Closed
rohanKanojia opened this issue May 17, 2023 · 7 comments · Fixed by #5345
Closed

Upgrade Fabric8 Knative Extension Model to v0.37.0 #5140

rohanKanojia opened this issue May 17, 2023 · 7 comments · Fixed by #5345
Assignees
Labels
component/extensions Deals with the extensions enhancement
Milestone

Comments

@rohanKanojia
Copy link
Member

Is your task related to a problem? Please describe

Just like we're updating tekton extension in #4989, we should also bump knative extension to latest version (0.37.0 right now)

Describe the solution you'd like

Upgrade Knative extension model to v0.37.0

Describe alternatives you've considered

No response

Additional context

No response

@manusa manusa added enhancement component/extensions Deals with the extensions labels May 19, 2023
@andreaTP
Copy link
Member

IIRC the knative CRDs are already exposing a good API.
This makes it a good candidate to switch to totally generated extensions in the knative repository.

Any reference to a specific repository/CRDs we should look at?
Anyone from knative that can help and evaluate this effort?

@rohanKanojia
Copy link
Member Author

we can try doing it. But let's do it in a two-step process:

  1. Write tests for all exposed CRD types with go generator
  2. Migrate to Java generator (all tests written in previous step should still pass)

@andreaTP
Copy link
Member

Switching to the java-generator is going to be a breaking change, even if we test all of the types we need to convert them again.

@rohanKanojia
Copy link
Member Author

we need to convert them again.

Sorry, I don't understand this.

@andreaTP
Copy link
Member

The java-generator is not going to generate the same types as the current extension.

@manusa
Copy link
Member

manusa commented May 24, 2023

If it's possible, we should follow the same approach we did for Camel-K.

@rohanKanojia rohanKanojia changed the title Upgrade Fabric8 Knative Extension Model to Kubernetes v0.37.0 Upgrade Fabric8 Knative Extension Model to v0.37.0 Jul 21, 2023
@rohanKanojia rohanKanojia self-assigned this Jul 21, 2023
@rohanKanojia
Copy link
Member Author

This seems to be blocking my work on #5113 .

For now we can proceed with just updating go dependencies.

I've created #5348 for migration to Java generator task.

@manusa manusa added this to the 6.8.0 milestone Jul 21, 2023
@manusa manusa moved this to Review in Eclipse JKube Jul 21, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/extensions Deals with the extensions enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants