Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty flare key still transmits errors #22

Closed
tpetry opened this issue Apr 29, 2021 · 3 comments · Fixed by facade/ignition#381
Closed

Empty flare key still transmits errors #22

tpetry opened this issue Apr 29, 2021 · 3 comments · Fixed by facade/ignition#381

Comments

@tpetry
Copy link

tpetry commented Apr 29, 2021

On my development i "disabled" the flare error reporting by removing the flare key but still every exception is transmitted to flareapp.io. This is not something I would expect as it is transmitting many data (source code, database values) I did not consent to.

@freekmurze
Copy link
Collaborator

Our intention is not to transmit anything automatically when no key is provided.

Could you provide us with a demo app (or PHP script) where things are being transmitted to Flare when an API key isn't specified?

@tpetry
Copy link
Author

tpetry commented Apr 29, 2021

git clone git@github.com:tpetry/flare-client-php-issue22.git
cd flare-client-php-issue22
composer install
php artisan error

The flare logger has been configured, but no api key is provided. You do see my dd statement printing the flare report when it's contacting the flare server. It seems somewhere is a check missing whether an api key was configured.

@freekmurze
Copy link
Collaborator

We'll continue the conversation in facade/ignition#381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants