use id html attribute instead of name for in page anchors #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronami
force-pushed
the
use-ids-for-in-page-anchors
branch
from
31637d0
to
90bb2ee
Compare
ronami
force-pushed
the
use-ids-for-in-page-anchors
branch
from
90bb2ee
to
d0fe44d
Compare
JoelMarcey
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hey 👋
This is a small PR to use the
idHTML attribute instead ofnamefor in-page anchors. ThenameHTML attribute for anchors is obsolete since HTML5 (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a).On top of that, I also removed redundant anchor elements.