Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fby3.5: hd: Modify APML DIMM temperature sensor #462

Closed
wants to merge 2 commits into from
Closed

fby3.5: hd: Modify APML DIMM temperature sensor #462

wants to merge 2 commits into from

Conversation

Yi-Shum
Copy link
Collaborator

@Yi-Shum Yi-Shum commented Aug 4, 2022

Summary:

  • Read DIMM temperatures of TS0 and TS1, and select the higher as the
    result.

Dependency: #460

Test Plan:

  • Build Code: PASS

Log:

DIMMA Temp                   (0x5) :   39.00 C     | (ok)
DIMMB Temp                   (0x6) :   35.00 C     | (ok)
DIMMC Temp                   (0x7) :   34.75 C     | (ok)
DIMME Temp                   (0x8) :   34.00 C     | (ok)
DIMMG Temp                   (0x9) :   38.00 C     | (ok)
DIMMH Temp                   (0xA) :   35.00 C     | (ok)
DIMMI Temp                   (0xB) :   34.75 C     | (ok)
DIMMK Temp                   (0xC) :   34.75 C     | (ok)

@Yi-Shum
fby3.5: hd: Modify SDR table
fc42395 
Summary:
- Set UCT/LCT of some sensor.

Test Plan:
- Build Code: PASS
@Yi-Shum
fby3.5: hd: Modify APML DIMM temperature sensor
a826603 
Summary:
- Read DIMM temperatures of TS0 and TS1, and select the higher as the
result.

Test Plan:
- Build Code: PASS
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2022
@Yi-Shum Yi-Shum mentioned this pull request Aug 4, 2022
Closed
Yi-Shum added a commit to Yi-Shum/OpenBIC that referenced this pull request Aug 5, 2022
@Yi-Shum
fby3.5: hd: Support second source sensor
1c87fd9 
Summary:
- Support temperature sensor G788P87U.
- Support VR sensor xdpe19283b.
- Check HSC sensor type by GPIO HSC_TYPE_0/1.
- Check VR and temperature sensor type by board revision.

Test Plan:
- Build Code: PASS.

Log:
Second source board
```
Summary:

Support temperature sensor G788P87U.
Support VR sensor xdpe19283b.
Check HSC sensor type by GPIO HSC_TYPE_0/1.
Check VR and temperature sensor type by board revision.
Dependency: facebook#462

Test Plan:

Build Code: PASS.
Log:
Second source board

root@bmc-oob:~# sensor-util slot1
...
HSC Temp                     (0xE) :   48.12 C     | (ok)
CPU0 VR Temp                 (0xF) :   57.00 C     | (ok)
SOC VR Temp                  (0x10) :   56.00 C     | (ok)
CPU1 VR Temp                 (0x11) :   38.00 C     | (ok)
PVDDIO VR Temp               (0x12) :   38.00 C     | (ok)
PVDD11 VR Temp               (0x13) :   36.00 C     | (ok)
P12V_STBY Vol                (0x14) :   12.11 Volts | (ok)
PVDD18_S5 Vol                (0x15) :    1.83 Volts | (ok)
P3V3_STBY Vol                (0x16) :    3.34 Volts | (ok)
PVDD11_S3 Vol                (0x17) :    1.11 Volts | (ok)
P3V_BAT Vol                  (0x18) :    3.19 Volts | (ok)
PVDD33_S5 Vol                (0x19) :    3.34 Volts | (ok)
P5V_STBY Vol                 (0x1A) :    5.01 Volts | (ok)
P12V_MEM_1 Vol               (0x1B) :   12.11 Volts | (ok)
P12V_MEM_0 Vol               (0x1C) :   12.13 Volts | (ok)
P1V2_STBY Vol                (0x1D) :    1.21 Volts | (ok)
P3V3_M2 Vol                  (0x1E) :    3.33 Volts | (ok)
P1V8_STBY Vol                (0x1F) :    1.81 Volts | (ok)
HSC Input Vol                (0x20) :   12.05 Volts | (ok)
CPU0 VR Vol                  (0x21) :    0.92 Volts | (ok)
SOC VR Vol                   (0x22) :    1.19 Volts | (ok)
CPU1 VR Vol                  (0x23) :    0.92 Volts | (ok)
PVDDIO VR Vol                (0x24) :    1.10 Volts | (ok)
PVDD11 VR Vol                (0x25) :    1.10 Volts | (ok)
HSC Output Cur               (0x26) :   13.26 Amps  | (ok)
CPU0 VR Cur                  (0x27) :    8.56 Amps  | (ok)
SOC VR Cur                   (0x28) :   60.31 Amps  | (ok)
CPU1 VR Cur                  (0x29) :   13.69 Amps  | (ok)
PVDDIO VR Cur                (0x2A) :   29.00 Amps  | (ok)
PVDD11 VR Cur                (0x2B) :    2.00 Amps  | (ok)
HSC Input Pwr                (0x2C) :  159.84 Watts | (ok)
CPU0 VR Pwr                  (0x2D) :    7.88 Watts | (ok)
SOC VR Pwr                   (0x2E) :   72.12 Watts | (ok)
CPU1 VR Pwr                  (0x2F) :   12.38 Watts | (ok)
PVDDIO VR Pwr                (0x30) :   31.88 Watts | (ok)
PVDD11 VR Pwr                (0x31) :    2.25 Watts | (ok)
...
```
@facebook-github-bot
Copy link
Contributor

@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Aug 9, 2022
@Yi-Shum @facebook-github-bot
fby3.5: hd: Support second source sensor (#464)
2d74aa5 
Summary:
- Support temperature sensor G788P87U.
- Support VR sensor xdpe19283b.
- Check HSC sensor type by GPIO HSC_TYPE_0/1.
- Check VR and temperature sensor type by board revision.

Dependency: #462

Pull Request resolved: #464

Test Plan:
- Build Code: PASS.

Log:
Second source board
```
root@bmc-oob:~# sensor-util slot1
...
HSC Temp                     (0xE) :   48.12 C     | (ok)
CPU0 VR Temp                 (0xF) :   57.00 C     | (ok)
SOC VR Temp                  (0x10) :   56.00 C     | (ok)
CPU1 VR Temp                 (0x11) :   38.00 C     | (ok)
PVDDIO VR Temp               (0x12) :   38.00 C     | (ok)
PVDD11 VR Temp               (0x13) :   36.00 C     | (ok)
P12V_STBY Vol                (0x14) :   12.11 Volts | (ok)
PVDD18_S5 Vol                (0x15) :    1.83 Volts | (ok)
P3V3_STBY Vol                (0x16) :    3.34 Volts | (ok)
PVDD11_S3 Vol                (0x17) :    1.11 Volts | (ok)
P3V_BAT Vol                  (0x18) :    3.19 Volts | (ok)
PVDD33 (8abd13595b91e80483a23f1f1a3af919a502a536)_S5 Vol                (0x19) :    3.34 Volts | (ok)
P5V_STBY Vol                 (0x1A) :    5.01 Volts | (ok)
P12V_MEM_1 Vol               (0x1B) :   12.11 Volts | (ok)
P12V_MEM_0 Vol               (0x1C) :   12.13 Volts | (ok)
P1V2_STBY Vol                (0x1D) :    1.21 Volts | (ok)
P3V3_M2 Vol                  (0x1E) :    3.33 Volts | (ok)
P1V8_STBY Vol                (0x1F) :    1.81 Volts | (ok)
HSC Input Vol                (0x20) :   12.05 Volts | (ok)
CPU0 VR Vol                  (0x21) :    0.92 Volts | (ok)
SOC VR Vol                   (0x22) :    1.19 Volts | (ok)
CPU1 VR Vol                  (0x23) :    0.92 Volts | (ok)
PVDDIO VR Vol                (0x24) :    1.10 Volts | (ok)
PVDD11 VR Vol                (0x25) :    1.10 Volts | (ok)
HSC Output Cur               (0x26) :   13.26 Amps  | (ok)
CPU0 VR Cur                  (0x27) :    8.56 Amps  | (ok)
SOC VR Cur                   (0x28) :   60.31 Amps  | (ok)
CPU1 VR Cur                  (0x29) :   13.69 Amps  | (ok)
PVDDIO VR Cur                (0x2A) :   29.00 Amps  | (ok)
PVDD11 VR Cur                (0x2B) :    2.00 Amps  | (ok)
HSC Input Pwr                (0x2C) :  159.84 Watts | (ok)
CPU0 VR Pwr                  (0x2D) :    7.88 Watts | (ok)
SOC VR Pwr                   (0x2E) :   72.12 Watts | (ok)
CPU1 VR Pwr                  (0x2F) :   12.38 Watts | (ok)
PVDDIO VR Pwr                (0x30) :   31.88 Watts | (ok)
PVDD11 VR Pwr                (0x31) :    2.25 Watts | (ok)
...
```

Reviewed By: garnermic

Differential Revision: D38518261

Pulled By: GoldenBug

fbshipit-source-id: 8bf11ece8801ff66a23ea0d3f8f0b146db43b73f
Scron-Chang pushed a commit to Scron-Chang/OpenBIC that referenced this pull request Aug 10, 2022
@Yi-Shum @Scron-Chang
fby3.5: hd: Support second source sensor
51395b4 
Summary:
- Support temperature sensor G788P87U.
- Support VR sensor xdpe19283b.
- Check HSC sensor type by GPIO HSC_TYPE_0/1.
- Check VR and temperature sensor type by board revision.

Test Plan:
- Build Code: PASS.

Log:
Second source board
```
Summary:

Support temperature sensor G788P87U.
Support VR sensor xdpe19283b.
Check HSC sensor type by GPIO HSC_TYPE_0/1.
Check VR and temperature sensor type by board revision.
Dependency: facebook#462

Test Plan:

Build Code: PASS.
Log:
Second source board

root@bmc-oob:~# sensor-util slot1
...
HSC Temp                     (0xE) :   48.12 C     | (ok)
CPU0 VR Temp                 (0xF) :   57.00 C     | (ok)
SOC VR Temp                  (0x10) :   56.00 C     | (ok)
CPU1 VR Temp                 (0x11) :   38.00 C     | (ok)
PVDDIO VR Temp               (0x12) :   38.00 C     | (ok)
PVDD11 VR Temp               (0x13) :   36.00 C     | (ok)
P12V_STBY Vol                (0x14) :   12.11 Volts | (ok)
PVDD18_S5 Vol                (0x15) :    1.83 Volts | (ok)
P3V3_STBY Vol                (0x16) :    3.34 Volts | (ok)
PVDD11_S3 Vol                (0x17) :    1.11 Volts | (ok)
P3V_BAT Vol                  (0x18) :    3.19 Volts | (ok)
PVDD33_S5 Vol                (0x19) :    3.34 Volts | (ok)
P5V_STBY Vol                 (0x1A) :    5.01 Volts | (ok)
P12V_MEM_1 Vol               (0x1B) :   12.11 Volts | (ok)
P12V_MEM_0 Vol               (0x1C) :   12.13 Volts | (ok)
P1V2_STBY Vol                (0x1D) :    1.21 Volts | (ok)
P3V3_M2 Vol                  (0x1E) :    3.33 Volts | (ok)
P1V8_STBY Vol                (0x1F) :    1.81 Volts | (ok)
HSC Input Vol                (0x20) :   12.05 Volts | (ok)
CPU0 VR Vol                  (0x21) :    0.92 Volts | (ok)
SOC VR Vol                   (0x22) :    1.19 Volts | (ok)
CPU1 VR Vol                  (0x23) :    0.92 Volts | (ok)
PVDDIO VR Vol                (0x24) :    1.10 Volts | (ok)
PVDD11 VR Vol                (0x25) :    1.10 Volts | (ok)
HSC Output Cur               (0x26) :   13.26 Amps  | (ok)
CPU0 VR Cur                  (0x27) :    8.56 Amps  | (ok)
SOC VR Cur                   (0x28) :   60.31 Amps  | (ok)
CPU1 VR Cur                  (0x29) :   13.69 Amps  | (ok)
PVDDIO VR Cur                (0x2A) :   29.00 Amps  | (ok)
PVDD11 VR Cur                (0x2B) :    2.00 Amps  | (ok)
HSC Input Pwr                (0x2C) :  159.84 Watts | (ok)
CPU0 VR Pwr                  (0x2D) :    7.88 Watts | (ok)
SOC VR Pwr                   (0x2E) :   72.12 Watts | (ok)
CPU1 VR Pwr                  (0x2F) :   12.38 Watts | (ok)
PVDDIO VR Pwr                (0x30) :   31.88 Watts | (ok)
PVDD11 VR Pwr                (0x31) :    2.25 Watts | (ok)
...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yi-Shum @facebook-github-bot