From 171e8fc00d4c7d430af7b27564baf3e82e573442 Mon Sep 17 00:00:00 2001 From: Ro Savage Date: Mon, 29 May 2017 14:49:40 +1200 Subject: [PATCH] Alternative fix for yarn crashing e2e tests on windows machines --- tasks/e2e-installs.sh | 18 ++++++++++++++---- tasks/e2e-kitchensink.sh | 18 ++++++++++++++---- tasks/e2e-simple.sh | 18 ++++++++++++++---- 3 files changed, 42 insertions(+), 12 deletions(-) diff --git a/tasks/e2e-installs.sh b/tasks/e2e-installs.sh index 0bdbbad6b56..8f4789ff0c7 100755 --- a/tasks/e2e-installs.sh +++ b/tasks/e2e-installs.sh @@ -86,10 +86,20 @@ root_path=$PWD # Clear cache to avoid issues with incorrect packages being used if hash yarnpkg 2>/dev/null then - # AppVeyor uses old version on yarn. - # Once updated to 0.24.3 or above install can be removed. - npm install -g yarn@latest - yarnpkg cache clean + # AppVeyor uses an old version of yarn. + # Once updated to 0.24.3 or above, the workaround can be removed + # and replaced with `yarnpkg cache clean` + # Issues: + # https://github.com/yarnpkg/yarn/issues/2591 + # https://github.com/appveyor/ci/issues/1576 + # https://github.com/facebookincubator/create-react-app/pull/2400 + # When removing workaround, you may run into + # https://github.com/facebookincubator/create-react-app/issues/2030 + case "$(uname -s)" in + *CYGWIN*|MSYS*|MINGW*) yarn=yarn.cmd;; + *) yarn=yarnpkg;; + esac + $yarn cache clean fi if hash npm 2>/dev/null diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh index 96b249c45c0..6270f00ac04 100755 --- a/tasks/e2e-kitchensink.sh +++ b/tasks/e2e-kitchensink.sh @@ -69,10 +69,20 @@ root_path=$PWD # Clear cache to avoid issues with incorrect packages being used if hash yarnpkg 2>/dev/null then - # AppVeyor uses old version on yarn. - # Once updated to 0.24.3 or above install can be removed. - npm install -g yarn@latest - yarnpkg cache clean + # AppVeyor uses an old version of yarn. + # Once updated to 0.24.3 or above, the workaround can be removed + # and replaced with `yarnpkg cache clean` + # Issues: + # https://github.com/yarnpkg/yarn/issues/2591 + # https://github.com/appveyor/ci/issues/1576 + # https://github.com/facebookincubator/create-react-app/pull/2400 + # When removing workaround, you may run into + # https://github.com/facebookincubator/create-react-app/issues/2030 + case "$(uname -s)" in + *CYGWIN*|MSYS*|MINGW*) yarn=yarn.cmd;; + *) yarn=yarnpkg;; + esac + $yarn cache clean fi if hash npm 2>/dev/null diff --git a/tasks/e2e-simple.sh b/tasks/e2e-simple.sh index abe3ce55878..163bec0818a 100755 --- a/tasks/e2e-simple.sh +++ b/tasks/e2e-simple.sh @@ -68,10 +68,20 @@ root_path=$PWD # Clear cache to avoid issues with incorrect packages being used if hash yarnpkg 2>/dev/null then - # AppVeyor uses old version on yarn. - # Once updated to 0.24.3 or above install can be removed. - npm install -g yarn@latest - yarnpkg cache clean + # AppVeyor uses an old version of yarn. + # Once updated to 0.24.3 or above, the workaround can be removed + # and replaced with `yarnpkg cache clean` + # Issues: + # https://github.com/yarnpkg/yarn/issues/2591 + # https://github.com/appveyor/ci/issues/1576 + # https://github.com/facebookincubator/create-react-app/pull/2400 + # When removing workaround, you may run into + # https://github.com/facebookincubator/create-react-app/issues/2030 + case "$(uname -s)" in + *CYGWIN*|MSYS*|MINGW*) yarn=yarn.cmd;; + *) yarn=yarnpkg;; + esac + $yarn cache clean fi if hash npm 2>/dev/null