Skip to content

Commit

Permalink
Remove unused e2e lines
Browse files Browse the repository at this point in the history
  • Loading branch information
EnoahNetzach committed Jan 30, 2017
1 parent 0f5e1b1 commit 62b3bf9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 36 deletions.
10 changes: 0 additions & 10 deletions tasks/e2e-installs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'`
function cleanup {
echo 'Cleaning up.'
cd $root_path
# Uncomment when snapshot testing is enabled by default:
# rm ./packages/react-scripts/template/src/__snapshots__/App.test.js.snap
rm -rf $temp_cli_path $temp_app_path
}

Expand Down Expand Up @@ -60,14 +58,6 @@ root_path=$PWD

npm install

# If the node version is < 4, the script should just give an error.
if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ]
then
cd $temp_app_path
err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''`
[[ $err_output =~ You\ are\ running\ Node ]] && exit 0 || exit 1
fi

if [ "$USE_YARN" = "yes" ]
then
# Install Yarn so that the test can use it to install packages.
Expand Down
26 changes: 0 additions & 26 deletions tasks/e2e-kitchensink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'`
function cleanup {
echo 'Cleaning up.'
cd $root_path
# Uncomment when snapshot testing is enabled by default:
# rm ./packages/react-scripts/template/src/__snapshots__/App.test.js.snap
rm -rf $temp_cli_path $temp_app_path
}

Expand Down Expand Up @@ -60,14 +58,6 @@ root_path=$PWD

npm install

# If the node version is < 4, the script should just give an error.
if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ]
then
cd $temp_app_path
err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''`
[[ $err_output =~ You\ are\ running\ Node ]] && exit 0 || exit 1
fi

if [ "$USE_YARN" = "yes" ]
then
# Install Yarn so that the test can use it to install packages.
Expand All @@ -93,9 +83,6 @@ cp package.json package.json.orig
# of those packages.
node $root_path/tasks/replace-own-deps.js

# Remove .npmignore so the test template is added
rm $root_path/packages/react-scripts/.npmignore

# Finally, pack react-scripts
scripts_path=$root_path/packages/react-scripts/`npm pack`

Expand Down Expand Up @@ -153,13 +140,6 @@ E2E_FILE=./build/index.html \
NODE_PATH=src \
node_modules/.bin/mocha --require babel-register --require babel-polyfill integration/*.test.js

# Uncomment when snapshot testing is enabled by default:
# test -e src/__snapshots__/App.test.js.snap

# Test the server
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell NODE_PATH=src npm start -- --smoke-test
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell HTTPS=true NODE_PATH=src npm start -- --smoke-test

# ******************************************************************************
# Finally, let's check that everything still works after ejecting.
# ******************************************************************************
Expand Down Expand Up @@ -208,11 +188,5 @@ E2E_FILE=./build/index.html \
NODE_PATH=src \
node_modules/.bin/mocha --require babel-register --require babel-polyfill integration/*.test.js

# Uncomment when snapshot testing is enabled by default:
# test -e src/__snapshots__/App.test.js.snap

# Test the server
REACT_APP_SHELL_ENV_MESSAGE=fromtheshell NODE_PATH=src npm start -- --smoke-test

# Cleanup
cleanup

0 comments on commit 62b3bf9

Please sign in to comment.