diff --git a/tasks/e2e-installs.sh b/tasks/e2e-installs.sh index f3c1d8d3bd0..7bb4c0392f2 100755 --- a/tasks/e2e-installs.sh +++ b/tasks/e2e-installs.sh @@ -22,8 +22,6 @@ temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'` function cleanup { echo 'Cleaning up.' cd $root_path - # Uncomment when snapshot testing is enabled by default: - # rm ./packages/react-scripts/template/src/__snapshots__/App.test.js.snap rm -rf $temp_cli_path $temp_app_path } @@ -60,14 +58,6 @@ root_path=$PWD npm install -# If the node version is < 4, the script should just give an error. -if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ] -then - cd $temp_app_path - err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''` - [[ $err_output =~ You\ are\ running\ Node ]] && exit 0 || exit 1 -fi - if [ "$USE_YARN" = "yes" ] then # Install Yarn so that the test can use it to install packages. diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh index 4e455e7e116..892230ab747 100755 --- a/tasks/e2e-kitchensink.sh +++ b/tasks/e2e-kitchensink.sh @@ -22,8 +22,6 @@ temp_app_path=`mktemp -d 2>/dev/null || mktemp -d -t 'temp_app_path'` function cleanup { echo 'Cleaning up.' cd $root_path - # Uncomment when snapshot testing is enabled by default: - # rm ./packages/react-scripts/template/src/__snapshots__/App.test.js.snap rm -rf $temp_cli_path $temp_app_path } @@ -60,14 +58,6 @@ root_path=$PWD npm install -# If the node version is < 4, the script should just give an error. -if [ `node --version | sed -e 's/^v//' -e 's/\..\+//g'` -lt 4 ] -then - cd $temp_app_path - err_output=`node "$root_path"/packages/create-react-app/index.js test-node-version 2>&1 > /dev/null || echo ''` - [[ $err_output =~ You\ are\ running\ Node ]] && exit 0 || exit 1 -fi - if [ "$USE_YARN" = "yes" ] then # Install Yarn so that the test can use it to install packages. @@ -93,9 +83,6 @@ cp package.json package.json.orig # of those packages. node $root_path/tasks/replace-own-deps.js -# Remove .npmignore so the test template is added -rm $root_path/packages/react-scripts/.npmignore - # Finally, pack react-scripts scripts_path=$root_path/packages/react-scripts/`npm pack` @@ -153,13 +140,6 @@ E2E_FILE=./build/index.html \ NODE_PATH=src \ node_modules/.bin/mocha --require babel-register --require babel-polyfill integration/*.test.js -# Uncomment when snapshot testing is enabled by default: -# test -e src/__snapshots__/App.test.js.snap - -# Test the server -REACT_APP_SHELL_ENV_MESSAGE=fromtheshell NODE_PATH=src npm start -- --smoke-test -REACT_APP_SHELL_ENV_MESSAGE=fromtheshell HTTPS=true NODE_PATH=src npm start -- --smoke-test - # ****************************************************************************** # Finally, let's check that everything still works after ejecting. # ****************************************************************************** @@ -208,11 +188,5 @@ E2E_FILE=./build/index.html \ NODE_PATH=src \ node_modules/.bin/mocha --require babel-register --require babel-polyfill integration/*.test.js -# Uncomment when snapshot testing is enabled by default: -# test -e src/__snapshots__/App.test.js.snap - -# Test the server -REACT_APP_SHELL_ENV_MESSAGE=fromtheshell NODE_PATH=src npm start -- --smoke-test - # Cleanup cleanup