Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel loader does not seem to handle numeric separators in external packages #11494

Open
l-monninger opened this issue Sep 30, 2021 · 3 comments

Comments

@l-monninger
Copy link

l-monninger commented Sep 30, 2021

Describe the bug

The babel loader used with run does not appear to handle numeric separators in 4.0.3. I have not tested other versions.

Did you try recovering your dependencies?

Yes.

Which terms did you search for in User Guide?

Yes.

Environment

react-scripts 4.0.03
node v14.17.4
typescript 4.2.4

Steps to reproduce

  1. Create React App.
  2. Add module that uses numeric separators (color 4.0.1 for example)
  3. Attempt to import module that uses numeric separators.
  4. react-scripts run

Expected behavior

The app compiles and runs.

Actual behavior

The app does not compile.

Reproducible demo

https://github.com/l-monninger/react-scripts-numeric-separators-demo

@nrayburn-tech
Copy link

Same as #11339.

@l-monninger
Copy link
Author

@nrayburn-tech is this the recommendation just to eject for now?

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants