Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn + Create React App Umbrella #1189

Closed
7 of 12 tasks
gaearon opened this issue Dec 7, 2016 · 12 comments
Closed
7 of 12 tasks

Yarn + Create React App Umbrella #1189

gaearon opened this issue Dec 7, 2016 · 12 comments
Assignees

Comments

@gaearon
Copy link
Contributor

gaearon commented Dec 7, 2016

We shipped Yarn integration but there are a few small annoyances.
I'd like to consolidate them.

When they are fixed I'll feel comfortable recommending Yarn to CRA users more broadly.

@Daniel15
Copy link
Member

Daniel15 commented Dec 13, 2016

I want to make sure we have a process in place that Yarn RC releases don't become latest until they're well tested.

This is tracked in yarnpkg/yarn#2161.

@ffxsam
Copy link

ffxsam commented Dec 17, 2016

This issue I posted might be related:
yarnpkg/yarn#2229

I was excited to start using it with my Meteor projects, but went back to npm as I don't find yarn to be all that reliable.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 3, 2017

Also interesting: apparently installed size is larger with Yarn? https://twitter.com/petrhurtak/status/812356423795568640

@gaearon
Copy link
Contributor Author

gaearon commented Jan 10, 2017

Apparently the disk size issue is very bad.
https://twitter.com/nicdex/status/818606636919095296

@Daniel15
Copy link
Member

The disk size issue might be related to yarnpkg/yarn#2306. It'd be worth opening an issue on the Yarn GitHub project to track it.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 11, 2017

Another issue report related to binaries: #1370.
Not sure if diagnosis is correct.

@Timer
Copy link
Contributor

Timer commented Feb 6, 2017

-snip- yarnpkg/yarn#2649

@gaearon
Copy link
Contributor Author

gaearon commented Feb 6, 2017

@Timer Mind filing a Yarn bug?

@Timer
Copy link
Contributor

Timer commented Feb 6, 2017

Filed. 😄

@fson
Copy link
Contributor

fson commented Apr 10, 2017

Unmet peer dependency warning (yarnpkg/yarn#2132) has been fixed in Yarn 0.22.0.

@dannylewis-sheffield
Copy link

With regard to "issues with flaky connections" I've added the following comment on yarnpkg/yarn#746

OK I had the same issues when building create-react-app inside docker, never managed to install.

Backed out one step to the vagrant box, running on VirtualBox, installed node yarn etc and then again ran create-react-app. Same issue but it did get further, downloaded more packages, than under docker.

Changed the network settings on vagrant from NAT to Bridged:

Old:
config.vm.network :forwarded_port, guest: 80, host: 1026, auto_correct: true

New:
config.vm.network :public_network, :public_network => "wlan0"

You can switch back the configs once you have successfully done what you needed to.

Ran create-react-app again and it looked like it it would complete, despite the odd "warning There appears to be trouble with your network connection. Retrying..." Nope failed on ESOCKETTIMEDOUT, but just about there!

Ran it again, success!

Back to docker version, long story short it eventually successfully built. Good job I'm doing intermediate builds...

Networks can be flaky, some more than others.

I would like to see the following be able to be set in yarn config:

download_max_retry - does what it says on the tin and defaults to 20
download_clear_failed_count_on_success - true or false, default false, if true would reset the failed download count to 0 on the next successful download, this would mean it would only fail to complete if it failed to download the last file in the queue (assuming downloads are parallel, some fail and are then put back in the queue)

Hope this helps and thanks for the tools!

@gaearon
Copy link
Contributor Author

gaearon commented Jan 8, 2018

Seems like this is as good as it gets for now.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants