Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not reuse tab from Google Chrome Dev and Google Chrome Beta when starting #12411

Closed
nvh95 opened this issue May 18, 2022 · 0 comments · Fixed by #12412
Closed

Does not reuse tab from Google Chrome Dev and Google Chrome Beta when starting #12411

nvh95 opened this issue May 18, 2022 · 0 comments · Fixed by #12412

Comments

@nvh95
Copy link
Contributor

nvh95 commented May 18, 2022

Describe the bug

On MacOS, if the users have both Google Chrome and Google Chrome Dev installed, but they have only Google Chrome Dev opened. Then, startBrowserProcess will not reuse the opening tab in Google Chrome Dev, but open a new tab in Google Chrome.

This happens with Google Chrome Beta as well, but not Google Chrome Canary (since it's already in the list).

I did create a PR to fix this (#12412)

Reproducible demo

Screen.Recording.2022-05-19.at.01.16.40.mov

Environment

Click to expand!

Environment Info:

current version of create-react-app: 5.0.1
running from /Users/somewhere/.npm/_npx/c67e74de0542c87c/node_modules/create-react-app

System:
OS: macOS 12.0.1
CPU: (8) arm64 Apple M1
Binaries:
Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
Yarn: 1.22.15 - ~/.nvm/versions/node/v16.15.0/bin/yarn
npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
Browsers:
Chrome: 101.0.4951.64
Edge: Not Found
Firefox: Not Found
Safari: 15.1
npmPackages:
react: ^18.1.0 => 18.1.0
react-dom: ^18.1.0 => 18.1.0
react-scripts: 5.0.1 => 5.0.1
npmGlobalPackages:
create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

  1. Have both Google Chrome and Google Chrome Dev installed
  2. Open only Google Chrome Dev
  3. Run react-scripts start

Expected behavior

App (http://localhost:3000) should open in Google Chrome Dev

Actual behavior

A new instance of Google Chrome is created and app (http://localhost:3000) is opened in a new tab in Google Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant