Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase verbosity for "Module not found" errors, to prevent case sensitiveness problems #1278

Closed
caesarsol opened this issue Dec 15, 2016 · 8 comments

Comments

@caesarsol
Copy link

caesarsol commented Dec 15, 2016

As discussed with @gaearon in #1260

My problem had to do with:

  • a local MacOS build (case insensitive) with files with the right casing
  • a git repository with wrong filenames casing
  • a remote CI build on a linux server, hence case sensitive

The CI builds failed, the local was OK, and I lost hours because I had no access to CI machine and I was misleaded by the undescriptive error message.

My proposal is to leverage something similar to the CaseSensitiveWebpackPlugin to give a more verbose error message, for example a directory listing or the searched paths.

@gaearon
Copy link
Contributor

gaearon commented Feb 11, 2017

Can you raise an issue with your suggestions in https://github.com/Urthen/case-sensitive-paths-webpack-plugin? It is not exactly clear to me what is actionable here on our side.

@edmundtfy
Copy link

@caesarsol So did you solve your problem? I seemed to always get this message, I don't know how to solve it. I have to comment out the react-script dev.webpack to get it working...

@caesarsol
Copy link
Author

Hey @edmundtfy,
I actually never opened the issue...

The problem was easily solved by changing the filenames in the git repo, to their right casing.
(case-insensitiveness makes this tricky: the easiest way was to rename to something else, commit, then rename back)

Going to open the issue on the plugin today!

@edmundtfy
Copy link

@caesarsol
hmm then I guess we are running into different issues? the git repo (as checked in github.com) has the correct upper-case folders and files
The case for me is

  1. branch out and make a new branch in a old git repo.
  2. install everything needed for create-react-app
  3. everything is working with yarn start and all.
  4. finished my branch to migrate to create-react-app, commit and push.
  5. git checkout master branch.
  6. git checkout my new branch again. yarn start starts giving case insensitive warning.

@caesarsol
Copy link
Author

Is it working after you restart the webpack server and/or reinstall all npm packages?

You may be running in something like Urthen/case-sensitive-paths-webpack-plugin#17?

@edmundtfy
Copy link

@caesarsol it is not working after restart, but is good after reinstall all npm packages... I guess more related to that issues you link to

@caesarsol
Copy link
Author

Thats surprising, I don't know if it has anything to do with this at this point. I'm sorry!

@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

Closing as stale.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants