Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let eslint check unused lodash import #1387

Closed
escaton opened this issue Jan 12, 2017 · 5 comments
Closed

Let eslint check unused lodash import #1387

escaton opened this issue Jan 12, 2017 · 5 comments

Comments

@escaton
Copy link

escaton commented Jan 12, 2017

I guess many developers imports lodash or underscore as _ but then it turns out that eslint ignores unused imports of that modules because of that line in config:
https://github.com/facebookincubator/create-react-app/blob/master/packages/eslint-config-react-app/index.js#L135

Is it necessary?

@gaearon
Copy link
Contributor

gaearon commented Jan 12, 2017

It’s often pretty useful. Since even Lodash itself doesn’t recommend using the single import I think it’s fine to be honest.

@escaton
Copy link
Author

escaton commented Jan 12, 2017

Actually i find this while replacing single imports :) but i was searching for _.* and missed unused imports.

@gaearon
Copy link
Contributor

gaearon commented Feb 11, 2017

Going to close unless more people bump into this problem. Thanks for reporting in either case!

@gaearon
Copy link
Contributor

gaearon commented Mar 5, 2017

We’re going to fix it in #1719.

@escaton
Copy link
Author

escaton commented Mar 5, 2017

👍

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants