-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases to validate functionality of PUBLIC_URL and relative homepage #1516
Comments
.
homepage
The test runner would have to
for each test case. A way to test them could be that of compiling them in various cases, and look for usages in the code afterward (similar to what is done here.) This way could be really demanding for travis' CI timewise, though.. Another open question is: should there be a difference between production and development, therefore tested? |
That's exactly what I had in mind, so it's great to hear that you're on the same page @EnoahNetzach. I think testing this case warrants some extra CI time, but I believe it's something we only have to test on Node 6. Also, we removed the PUBLIC_URL effect in development so it remained the same as before. I want to test that it's not respected. |
Probably the long execution of "kitchensink" in node 4 lets us add another job to the travis' matrix, dedicated to this (and maybe future related) problems. I'd try it creating a new project each time (similar to "installs"), and see how much it takes.. For testing I think a simple Which are the test cases, and the expected outputs? For the
For the
Am I right? |
Correct @EnoahNetzach -- but we should also check the Checking |
Are you giving this a whirl, @EnoahNetzach? Or should I try to pull something together? |
Started #1519. Feel free to contribute. |
@Timer you go, I'll watch and judge 😛 |
I'd love a review on #1519 @EnoahNetzach. |
@Timer tomorrow I'll be more than happy |
What's left here? |
The bash implementation isn't preferable, we would probably benefit more from a more comprehensive entry in kitchensink that uses jest. |
Closing as stale. |
We recently added
PUBLIC_URL
support and official.
(relative) homepage support.I think it's very important to test these behaviors to ensure they're being properly applied.
PUBLIC_URL
is already partially tested but could be improved, and there exists no test for relative homepage support.#1519 is the first step of this, we need much deeper integration testing (with other assets, maybe include bootstrap).
The text was updated successfully, but these errors were encountered: