Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why e2e script doesn't catch some issues #163

Closed
gaearon opened this issue Jul 24, 2016 · 2 comments · Fixed by #244
Closed

Figure out why e2e script doesn't catch some issues #163

gaearon opened this issue Jul 24, 2016 · 2 comments · Fixed by #244

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 24, 2016

npm run build currently fails due to #162 (comment).
However e2e script didn't catch it.

@dhruska
Copy link
Contributor

dhruska commented Jul 25, 2016

I think the issue here is that the e2e script is running the build task with the --debug-template flag, so the relative path in build.js is ./template. When running the actual build task in a new project, that flag isn't set so a different relative path is used. Not sure what the best solution is to prevent this, but that explains the missed error.

@gaearon
Copy link
Contributor Author

gaearon commented Jul 25, 2016

I think it only uses this flag the first time, but it should later create a separate directory and run a regular build there.

@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants