-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react and react-dom dependencies should have caret range #1663
Comments
@gaearon it is kinda wired. |
my suggestion would be as you already mentioned to remove the |
The init script only does this for backwards compatibility with older global CLIs. It is still necessary because we want older CLIs to keep working. |
thx for clearing that up. One additional question, there exists some mechanism to install additional dependencies listed in a templates.dependeny.json file That mechanism is obsolete? |
No, that that code is used for our kitchensink e2e. |
ok :) lots to learn here Tried out some variants with installing different versions with npm and it seems that it is not possible to install with different modes during an single install. The dependecies will be downloaded and installed with the correct version pattern, but the dependencies in the package.json will all get the same version range. e.g.
One way to solve that would be to patch the package.json upfront and afterwards trigger an install. |
Yes, we already patch up |
THX that will be a perfect spot. Try to formulate a PR. |
Fixed in #1669. Thanks @johann-sonntagbauer! |
I think #1253 made it so that
react
andreact-dom
are also installed with exact range:This is not right. We want to pin
react-scripts
but leavereact
andreact-dom
unpinned:The easiest way to do it would probably be to remove the
exact
flag from the installation script inpackages/create-react-app/index.js
, and instead pinreact-scripts
to a specific version in the same function that movesreact-scripts
todevDependencies
(also in that file).The text was updated successfully, but these errors were encountered: