Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ejecting from a scoped fork of react-scripts doesn't work #1722

Closed
gaearon opened this issue Mar 5, 2017 · 0 comments · Fixed by #1727
Closed

Ejecting from a scoped fork of react-scripts doesn't work #1722

gaearon opened this issue Mar 5, 2017 · 0 comments · Fixed by #1727
Labels
issue: bug
Milestone
0.9.4

Comments

@gaearon
Copy link
Contributor

gaearon commented Mar 5, 2017 •
edited
Loading

Related to #1414.

Even after #1706 fixes it, ejecting still won't work because the package will be one folder deeper.

We should fix our folder resolution to understand scoped packages.

As we fix this we should also remember to test the npm link integration in case it breaks.
@gaearon gaearon added this to the 0.9.4 milestone Mar 5, 2017
@gaearon gaearon mentioned this issue Mar 5, 2017
Merged
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
0.9.4
Development

Successfully merging a pull request may close this issue.

Fix ejecting from a scoped fork gaearon/create-react-app
1 participant
@gaearon