Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom domain, and CNAME file #1804

Closed
jdeniau opened this issue Mar 12, 2017 · 1 comment
Closed

Custom domain, and CNAME file #1804

jdeniau opened this issue Mar 12, 2017 · 1 comment

Comments

@jdeniau
Copy link

jdeniau commented Mar 12, 2017

I was filling an issue on how the CNAME file was erased every time when deploying with gh-pages when I saw it was written in the documentation.

The fact is that the custom domains are written in the homepage value in the package.json file.

Can create-react-app auto-generate this CNAME in the gh-pages branch if the homepage does not match /\.github\.io/ ?

@gaearon
Copy link
Contributor

gaearon commented Mar 12, 2017

I think putting it in the public/ folder as suggested in the docs is a reasonable solution.

Can create-react-app auto-generate this CNAME in the gh-pages branch if the homepage does not match /.github.io/ ?

I’d rather not mess with git branches from the tool—that can be pretty confusing.
Also, some people deploy from docs folder instead (new GH option).

@gaearon gaearon closed this as completed Mar 12, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants