Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty CSS sourcemaps created in a production build #2026

Closed
viankakrisna opened this issue Apr 24, 2017 · 0 comments
Closed

Empty CSS sourcemaps created in a production build #2026

viankakrisna opened this issue Apr 24, 2017 · 0 comments

Comments

@viankakrisna
Copy link
Contributor

a follow up to #2013 (comment)

It's confusing that CRA created an empty .map for css when running npm run build. I thought that it should generate a proper .map file on minify so i've turned the option on that pr. But turns out that css source map is quite problematic (for development) based on #591

So the question right now is whether we should find out why it creates an empty and confusing .map for css file on production, or just turn it on? I don't think it would affect production perf though. http://stackoverflow.com/questions/23848364/performance-impact-of-using-css-javascript-source-maps-in-production and maybe would be beneficial if there is problem with production css.

@gaearon gaearon added this to the 0.10.0 milestone Apr 25, 2017
@gaearon gaearon changed the title [0.10.0] CSS Source Map on production. Turned off but still created an empty .map file on production build Empty CSS sourcemaps created in a production build May 15, 2017
@gaearon gaearon modified the milestones: 0.11.0, 0.10.0 May 15, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants