Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hacky code with a custom ESLint formatter #2121

Closed
gaearon opened this issue May 11, 2017 · 1 comment
Closed

Replace hacky code with a custom ESLint formatter #2121

gaearon opened this issue May 11, 2017 · 1 comment
Labels
contributions: claimed difficulty: medium tag: internal

Comments

@gaearon
Copy link
Contributor

gaearon commented May 11, 2017

This is not really maintainable.

Instead we should write a custom ESLint formatter. The initial version should probably do exactly the same format we support on master, but without the hacky string manipulations.
@gaearon gaearon mentioned this issue May 11, 2017
Merged
@sidoshi sidoshi mentioned this issue May 12, 2017
Closed
@sidoshi
Copy link
Contributor

sidoshi commented May 12, 2017

I went ahead and wrote a custom formatter. See #2136

@sidoshi sidoshi mentioned this issue May 12, 2017
Merged
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed difficulty: medium tag: internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @sidoshi