Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS @keyframes Best Practice #219

Closed
hnordt opened this issue Jul 26, 2016 · 2 comments
Closed

CSS @keyframes Best Practice #219

hnordt opened this issue Jul 26, 2016 · 2 comments

Comments

@hnordt
Copy link
Contributor

hnordt commented Jul 26, 2016 •
edited
Loading

In src/App.css we have the @keyframes spin rule:

@keyframes spin {
  from { transform: rotate(0deg); }
  to { transform: rotate(360deg); }
}

Wouldn't best to rename spin to App-logo-spin? That way we teach newcomers to avoid "CSS globals" for everything.

I mean, @keyframes spin is a good candidate to be added in many component's CSS file.
@vjeux
Copy link
Contributor

vjeux commented Jul 26, 2016

👍 want to send a pull request?

@hnordt
Copy link
Contributor Author

hnordt commented Jul 26, 2016

@vjeux sure, doing it now.

@hnordt hnordt mentioned this issue Jul 26, 2016
Merged
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vjeux @hnordt