Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss full page reload after fixing compile errors #2217

Closed
RohovDmytro opened this issue May 18, 2017 · 3 comments
Closed

Dismiss full page reload after fixing compile errors #2217

RohovDmytro opened this issue May 18, 2017 · 3 comments

Comments

@RohovDmytro
Copy link

After making some tweaks and introducing a type in a component name

<ComponentThatDoNotExistDefinataly />

So we have compilation error. And fixing that typo leads to full page reload.

But wouldn't that be nice, if we could reject that hot-update-patch and swap it only if compilation succeeded? Or use another approach but the aim is to prevent page from reloading after fixing that typo.

@RohovDmytro RohovDmytro changed the title Dismiss full page reload after compile errors Dismiss full page reload after fixing compile errors May 18, 2017
@gaearon
Copy link
Contributor

gaearon commented May 18, 2017

Want to make a proof of concept?

As I wrote in gaearon/react-hot-boilerplate#97 (comment), for me personally one of the goals of this project is to make a stable hot reloading experience part of React by default.

Syntax and runtime overlays are a necessary first step, and I’m excited to move beyond them and make the experience better now that more pieces are in place.

@RohovDmytro
Copy link
Author

create-react-app made me to forget about all the inner part of webpack and other stuff 😕 Not sure I will have enough time to digg into. But I will surely help with testing stuff, because I am very excited about HMR too and it make my workflow so much better.

@Timer
Copy link
Contributor

Timer commented Sep 29, 2017

I believe a concept for this is up in #2304, I'll close this for now. 😄

@Timer Timer closed this as completed Sep 29, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants