Forgetting to return JSX should crash the build

[gaearon]

This should crash the build:

(Note I didn't return it.)

Instead it is just a lint warning:

./packages/react-scripts/template/src/Logo.js
  Line 5:  Expected an assignment or function call and instead saw an expression  no-unused-expressions

We should probably promote it to be an error.

[amupitan]

Can I work on this? Also, what file(s) can I look at concerning the issue?

[gaearon]

Sure. You could look at our ESLint config.

[amoghpalnitkar]

I would like to contribute to this. Don't see any PRs on this yet.
Is it up for grabs?

[gaearon]

There is #2319 (you could see it linked above your comment), but thanks for the suggestion!

[amoghpalnitkar]

Oh of course. How did I miss that. My bad!

[MayasHaddad]

@gaearon I see the issue is still open, while the problem is solved.

Do you guys close issues after release?