-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSizeReporter reports with wrong (hardcoded) path. #2357
Comments
Good catch. Want to send a PR that passes appBuild folder into that function? |
@gaearon It's my pleasure. |
This never made it into the documentation, which still incorrectly states
when in fact it should be
or this happens
|
Good point. Want to send a PR? |
Reopened for docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Can you reproduce the problem with latest npm?
yes
Description
When i changed the value of
appBuild
property todist
in "react-scripts/config/paths.js" and runnpm run build
, theprintFileSizesAfterBuild
function logged wrong paths.Expected behavior
Log in the console should be like:
Actual behavior
But it still reported with "build" in paths:
Environment
Run these commands in the project folder and fill in their results:
npm ls react-scripts
(if you haven’t ejected):node -v
: v7.4.0npm -v
: 4.0.5Then, specify:
Hardcode
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-dev-utils/FileSizeReporter.js#L33
The text was updated successfully, but these errors were encountered: