Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint - no-unused-expressions warning for template tags #2647

Closed
ffxsam opened this issue Jun 27, 2017 · 4 comments
Closed

ESLint - no-unused-expressions warning for template tags #2647

ffxsam opened this issue Jun 27, 2017 · 4 comments

Comments

@ffxsam
Copy link

ffxsam commented Jun 27, 2017

I'm using styled-components' injectGlobal template tag function, like so:

injectGlobal`
  .ant-btn-clicked:after {
    border: 0 solid ${mainTheme.primaryColor.toString()} !important;
  }

  .ant-switch-checked {
    background-color: ${mainTheme.primaryColor.toString()} !important;
    border-color: ${mainTheme.primaryColor.toString()} !important;
  }
`;

And I got warnings about injectGlobal being an unused expression. So I've modified my .eslintrc to be the following:

{
  "extends": "react-app",
  "rules": {
    "no-unused-expressions": ["error", {"allowTaggedTemplates": true}]
  }
}

This seems to stop ESLint warnings in Nuclide, but I'm still getting them in the browser console and shell:

./src/themes.js
  Line 20:  Expected an assignment or function call and instead saw an expression  no-unused-expressions

Am I configuring something wrong?

@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Overriding our ESLint settings is not really supported. It technically "works" for IDEs so we documented it, but we still want everyone to have the same base configuration. This helps make sure it works correctly for everyone, that bugfixes are coordinated, and that everyone has mostly good experience out of the box.

In this particular case it seems like we should change our config. Our stance is that we try to create a config that's good for most users rather than allow users to make individual tweaks, thus keeping the base config less ideal.

If you send a PR for fixing this in our config I'm happy to take that in.

@denkristoffer
Copy link
Contributor

This issue can be closed now 👍

@Timer
Copy link
Contributor

Timer commented Aug 10, 2017

Thanks!

@Timer Timer closed this as completed Aug 10, 2017
@Timer
Copy link
Contributor

Timer commented Aug 10, 2017

This feature has been released as of v1.0.11. :)

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants