Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation tells to install dev dependencies as dependencies #2716

Closed
klzns opened this issue Jul 3, 2017 · 1 comment
Closed

Documentation tells to install dev dependencies as dependencies #2716

klzns opened this issue Jul 3, 2017 · 1 comment

Comments

@klzns
Copy link

klzns commented Jul 3, 2017

Is this a bug report?

No.

I would like to know why the docs points to install dev dependencies as dependencies.

For example, it tells to install gh-pages, source-map-explorer, enzyme, react-test-renderer, jest-enzyme with npm install --save instead of npm install --save-dev.

The change was made in this PR:
#2660

Example:
screen shot 2017-07-03 at 11 53 05 am
@gaearon
Copy link
Contributor

gaearon commented Jul 3, 2017

Please see my response in https://stackoverflow.com/questions/44868453/create-react-app-install-devdepencies-in-dependencies-section/44872787#44872787.

@gaearon gaearon closed this as completed Jul 3, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klzns @gaearon