Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled errors are duplicated with React 16 #3011

Closed
gaearon opened this issue Aug 26, 2017 · 1 comment
Closed

Unhandled errors are duplicated with React 16 #3011

gaearon opened this issue Aug 26, 2017 · 1 comment
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Aug 26, 2017

Now I see two separate errors for every exception in React 16.
Probably because we throw it in a different context and then rethrow.

We should probably come up with some way to deduplicate them. In generally might be a good idea to always deduplicate identical errors since it's not helpful to switch between them anyway.

As we fix this we'll need to also test the overlay behavior for errors caught by boundaries. I'm not sure what the ideal behavior would be. We should probably always show our overlay I think.

@gaearon gaearon added this to the 1.0.12 milestone Aug 28, 2017
@gaearon
Copy link
Contributor Author

gaearon commented Aug 28, 2017

Fixed in 645dc42.

@gaearon gaearon closed this as completed Aug 28, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant