Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload doesn't happen after build errors in some cases #3015

Closed
gaearon opened this issue Aug 27, 2017 · 1 comment
Closed

Reload doesn't happen after build errors in some cases #3015

gaearon opened this issue Aug 27, 2017 · 1 comment

Comments

@gaearon
Copy link
Contributor

gaearon commented Aug 27, 2017

In particular, if I write:

class App extends Component {
  render() {
    setInterval(() => {
      throw new Error('no')
    })

Then introduce a syntax error.

Then fix it.

Expected: refresh happens.
Actual: we're stuck on the build error message.

@gaearon
Copy link
Contributor Author

gaearon commented Aug 28, 2017

Seems like this is just a case of setInterval calls getting in the way of webpack's Promise resolution (since Promises resolve asynchronously). I guess it's an uncommon case.

@gaearon gaearon closed this as completed Aug 28, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant