You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This idea came after the discussion in #2763 (comment), I think we should have a way to let our users test out experimental features easily. Therefore we can have a quick feedback of how these features would affect them and how to fix it, and whether or not that this is the right features for CRA.
Having tried to articulate an issue in a general way, but none worked, so I'll just try to post one of the solutions that I have in mind.
And that is to automate renaming the imports to scoped/renamed package.
IME forking react-scripts requires a lot of work, especially when you need to publish it to NPM and maintain it with upstream. And sometimes when you rebase with upstream you need to rename the imports because your fork uses scoped/renamed react-dev-utils / eslint-config-react-app and rebasing would revert the changes you made to the imports / require call.
We can automate the package scoping by providing a script to rename all reference to react-scripts, react-dev-utils, etc to the renamed/scoped version.
This way, forks can be easily rebased with upstream and more people can benefit from custom setup without ejecting / we provide plugin system.
For example, people can use react-scripts-relay and be sure that the churn for the maintainer of react-scripts-relay to be synced with upstream is just need to rebase, maybe resolve some conflicts, run the renaming script, test it, and publish it.
The text was updated successfully, but these errors were encountered:
yeah, I think @Timer already built the script that does exactly that for @react-scripts-dangerous, but I haven't had the chance to setup it for my own fork.
lockbot
locked and limited conversation to collaborators
Jan 20, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This idea came after the discussion in #2763 (comment), I think we should have a way to let our users test out experimental features easily. Therefore we can have a quick feedback of how these features would affect them and how to fix it, and whether or not that this is the right features for CRA.
Having tried to articulate an issue in a general way, but none worked, so I'll just try to post one of the solutions that I have in mind.
And that is to automate renaming the imports to scoped/renamed package.
IME forking react-scripts requires a lot of work, especially when you need to publish it to NPM and maintain it with upstream. And sometimes when you rebase with upstream you need to rename the imports because your fork uses scoped/renamed react-dev-utils / eslint-config-react-app and rebasing would revert the changes you made to the imports / require call.
We can automate the package scoping by providing a script to rename all reference to react-scripts, react-dev-utils, etc to the renamed/scoped version.
This way, forks can be easily rebased with upstream and more people can benefit from custom setup without ejecting / we provide plugin system.
For example, people can use react-scripts-relay and be sure that the churn for the maintainer of react-scripts-relay to be synced with upstream is just need to rebase, maybe resolve some conflicts, run the renaming script, test it, and publish it.
The text was updated successfully, but these errors were encountered: