Completely isolate the error overlay script from the main app

[gaearon]

I’m worried that if we add duplicate React detection (e.g. facebook/react-devtools#714), it will start firing in CRA development mode because react-error-overlay might ship with its own copy of React (e.g. if the app user deletes React but then adds an incompatible version). I’d like to avoid warning in such cases because it is intentional, and the iframe is meant to be completely opaque to the app developer.

I wonder if we can package the error overlay code in a way that it bundles React (rather than just importing it via CommonJS) and executes it in the context of the iframe (e.g. via iframeWindow.eval). Then DevTools shouldn’t “see“ React there.

Does this make any sense?

[gaearon]

@tharakawj Thoughts?

[tharakawj]

Technically this sounds possible though we have to figure it out how to do it. Also, I'm not sure parsing React code each time when we create a new iframe, will have any performance impact. Let me try some experiments around this and get back to you.

[tharakawj]

Created a PR for this! #3142
It was straightforward than I thought. And it works pretty fast as well. 😀
@gaearon I'd like to hear your feedback.